Custom marshaling fail on .NET Core makes libgit2sharp 0.25.2 fail

When upgrading nerdbank.gitversioning from my private libgit2sharp build of 0.24.7-g9fca61fdda to the official 0.25.2, which by the way added custom marshalers back into the codebase that I had originally removed for .NET Core 1.x support, we’re seeing frequent failures because .NET Core claims that the FilePath type isn’t seem as itself in the custom marshaler method.

My recommendation for a workaround is to switch back to my original .NET Core supporting solution for this project, which avoids custom marshalers altogether.

Other issues tracking the failure:

https://github.com/dotnet/coreclr/issues/19654 https://github.com/AArnott/Nerdbank.GitVersioning/issues/215

Version of LibGit2Sharp (release number or SHA1)

v0.25.2

Operating system(s) tested; .NET runtime tested

Windows, Ubuntu 18 .NET Framework and .NET Core

[ethomson]

My recommendation for a workaround is to switch back to my original .NET Core supporting solution for this project, which avoids custom marshalers altogether.

I think you’re talking about the changes that occurred in this nontrivial pull request? You can imagine that I’m not exactly jumping up and down at the thought of reverting this.

I’d like to hear what the .NET team has to say about this and possible workarounds before we start thinking about adding 500 lines of code back to the project that we removed nine months ago.

[AArnott]

Well, that and AArnott/Nerdbank.GitVersioning#217. The original fix for AArnott/Nerdbank.GitVersioning#215 was ineffective.