Uniform formatting format across library

The current library uses a mix of "" %, "%s".format and "{}".format everywhere.

"" % formatting is heavily outdated (up for debate), alongside it being relatively un-pythonic.

Since python 3.6 (the current minimally supported version of this library), “f-strings” were introduced, this formalizes down from "{}".format into f"{}":

value = "supercalifragilisticexpialidocious"

# Percentage formatting with symbol
"%s" % value

# Percentage formatting with format call
"%s".format(value)

# Brace formatting with format call
"{0!s}".format(value)

# Brace formatting with f-string
f"{value!s}"

Even if f-strings would not be a good, viable or a desirable candidate, I at least am asking if there would be a consistent formatting style across the library. With a coding style document somewhere to note this down, and/or linters to enforce this (flake8-pep3101 , flake8-string-format).

[ShadowJonathan]

So to summarize, and to make sure I got it right:

f-strings everywhere, except for log entries, which use %s (with its built-in formatter), correct?

[pipermerriam]

Note that there are good reasons why logging statements should use %s style formatting. 👍 to all of the others being consistent. f-strings are the current standard we’re using elsewhere.