question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move static test data to a submodule

See original GitHub issue

The test vectors significantly increase the repository size (See #240). I personally don’t see the benefit of designing tests against static MATLAB generated test vectors. Many scientific python users now are not using MATLAB anymore and therefore identical bit-exact output is not that crucial anymore. If you really want full MATLAB compatibility, dynamically generated vectors could better cover more test cases.

What about splitting the existing unit tests into functional tests (pure python) and MATLAB compatibility tests which could use oct2py (in case the matlab code runs on octave) or matlab_wrapper to run the tests without the intermediate vectors if available on local machines? For travis obviously only oct2py would work.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:12 (12 by maintainers)

github_iconTop GitHub Comments

1reaction
bmcfeecommented, Feb 17, 2022

This issue is back on my mind since we’re doing more intensive github action workflows now. This necessitates pushing around copies of the repo, which can get a bit costly and time-consuming.

To summarize: the proposal — from ahem 5 years ago — is to split tests/data off into a submodule and do a history-rewrite to remove purge the static files as if they were sensitive data.

We would need to also amend the CI action to pull in the submodule, and the contributor guidelines to include instructions on how to run tests.

1reaction
bmcfeecommented, Apr 18, 2017

I know I’m warming this up but why don’t we simply leave the static test vectors and put the data into a separate repo while linking back to this repo as a submodule?

Mostly because it’s a lot of work and not a high priority item for me right now. 😁

Seriously though, test refactoring is a huge job that needs to be done ( #391 ), so I’m open to splitting off numerical regression tests as part of that.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Git - Submodules - Git SCM
If you want to check for new work in a submodule, you can go into the directory and run git fetch and git...
Read more >
Moving submodules with Git [duplicate] - Stack Overflow
Move all content from the old to the new directory: mv -vi old/parent/submodule new/parent/submodule. Remove the old directory with git rm --cached old/parent/ ......
Read more >
Working with submodules - The GitHub Blog
Before you add a repository as a submodule, first check to see if you have a better alternative available. Git submodules work well...
Read more >
Using Git submodules with GitLab CI/CD
Use Git submodules in CI/CD jobs · You can set the GIT_SUBMODULE_STRATEGY variable to either normal or recursive to tell the runner to...
Read more >
Git submodule - Atlassian
Submodules are very static and only track specific commits. Submodules do not track git refs or branches and are not automatically updated when...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found