Bring back 'magic metrics'

This is the second part of the ticket https://github.com/lightdash/lightdash/issues/1969

State : No metrics defined in dbt project & we can detect magic metrics

• Add ‘magic metrics’ back in, but instead, put them under custom metrics.

State : Metrics are defined in dbt project

• No need to show ‘magic metrics’

All screens here: https://www.figma.com/file/Mhuwki1Bj1akQIwPyr1gWw/Lightdash-product?node-id=3545%3A75955

Tech notes: In the BE only generate magic metrics if there are no metrics in the dbt model. This way we don’t need any logic in the FE.

[TuringLovesDeathMetal]

@PriPatel we talked about this over the standup on Friday - all good! We’re going with the original design.

There were questions around being able to delete them, and having them pop back up (because the behaviour of these new “magic metrics” is slightly different to the old ones).

We’re sticking to the design!

[PriPatel]

I suggest magic metrics be custom metrics that are generated on the fly when the page loads. This will keep our UX and code simple and consistent.

Can we make them disappear when users have their own metrics?

Im a bit confused! Both of these are points are part of the original design? See my first comment:

State : No metrics defined in dbt project & we can detect magic metrics

Add ‘magic metrics’ back in, but instead, put them under custom metrics.

State : Metrics are defined in dbt project

No need to show ‘magic metrics’