question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

I want to update an existing space and make it restricted/shared

See original GitHub issue

User Acceptance Criteria

  • New spaces are created as restricted by default (only the person who created the space has access to it)
  • Once I’m in a space, I can adjust the access to that space (using the ‘share’ button)
  • I can switch a space between “full access” vs. “no access”
    • Switching between these just switches between their defaults (e.g. if I have a restricted space where I’ve also invited Priyanka, then I switch it to “shared”, then I switch it back to “restricted”, it would restrict the access to just me, it wouldn’t keep the old configurations and add Priyanka too)
  • You’re either given access to a space, or you aren’t. There’s no option to add someone as an editor vs. viewer when you’re inviting an individual.
  • Everyone inherits the permissions that they have at a project level. There’s no way to change these permissions in the spaces modal.
  • if a space is restricted, I can only add individuals to the space (for now). I can’t add groups of individuals (e.g. editors).
  • I can remove someone I’ve added to a restricted space

Frontend stuff User flow Components

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:11 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
TuringLovesDeathMetalcommented, Nov 9, 2022

^Yes, I think so!

This feels like a really common pattern in a lot of tools and I can imagine people requesting this later on. We’re not building it now because we couldn’t agree on “can you increase someone’s permissions” (e.g. I’m a project viewer, but you make me a space editor). So we tried to reduce the scope and just use “full access” vs. “restricted”

1reaction
owlascommented, Nov 9, 2022

Whoops that was a mistake. The is_private should live on the space table 🤦

In the spec permissions are inherited from their project role so we don’t need the access type on the space_share table. Although in future we’ll want to do that. So if it’s easier to add now rather than refactor, you could add an access to space_share and the space would return an access list like:

{
  "uuid": "810b43d0-fc0d-4199-8a79-25b471c880bf",
  "name": "Shared space",
  ...
  "isPrivate": true,
  "access": [
    { userUuid: "...", "access": "view"},
    { userUuid: "...", "access": "edit"}
    { userUuid: "..." },
  ],
}

access could be optional meaning that it inherits from the project? Or maybe that’s a bit confusing.

Simplest would be to not have any access on the space_share and inherit project perms

Read more comments on GitHub >

github_iconTop Results From Across the Web

Restricted Stock: A Helpful Guide (2022) - Contracts Counsel
Restricted stock is a form of compensation issued by a corporation to executives that are unregistered shares of ownership in the company.
Read more >
Restricted Stock: What It Is, How It Works, Selling & Taxation
Restricted stock refers to insider holdings that are under some kind of sales restriction and must be traded in compliance with special regulations....
Read more >
What You Need to Know About SPACs – Updated Investor ...
If the transaction is completed and you decide that you do not want to remain a shareholder, you will be provided with the...
Read more >
How to Protect Restricted Stock from Falling Prices or Poor ...
Restricted stock — given to or sold to an employee as an equity stake in a company — cannot be traded within a...
Read more >
Do you have restricted stock? Does an 83(b) Election make ...
The stock is restricted in the sense that before it can be enjoyed by the recipient the awarded stock is subject to vesting....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found