question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

There should be a 'View mode' for Saved charts

See original GitHub issue

Design files

Figma file and UI https://www.figma.com/file/Mhuwki1Bj1akQIwPyr1gWw/Lightdash-product?node-id=2583%3A46348

Prototype https://www.figma.com/proto/Mhuwki1Bj1akQIwPyr1gWw/Lightdash-product?node-id=2820%3A48838&scaling=min-zoom&page-id=2583%3A46348

The different modes

When should the user land on view mode? When they are opening a saved chart.

When should the user land on edit mode? When they hit ‘edit chart’ from the dashboard When the user hits ‘edit chart’ in view mode.

When should the user land on explore mode? When they have opened a link to an unsaved chart When they have clicked on Explore from here

Summary of UI changes

  • Sidebar animation of the drawer.
  • Filter panel should be disabled.
  • Show filters on hover.
  • In View mode, you should only be able to Export as in the charts panel
  • In View mode, you should only be able to Download CSV in the Results panel
  • Refresh dbt button style is less prominent
  • You should only be able to rename the chart/description in Edit mode ( this is different to how it works now)
  • Error messages should be shown on ‘View mode’ as well.
  • You should not be able to add to dashboard / delete / duplicate/ share when in Edit mode. (hide the context menu and actions!

Tickets:

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
PriPatelcommented, May 11, 2022

Thanks Katie !!

Ok - I’ve updated the original comment. Lets leave the CTAs as they are for now. We can change them in the future based on feedback, plus I don’t think they are critical to the concept of view/edit/explore modes.

The only bit missing right now is a better ‘share’ button. Im working on this now but I don’t think its a blocker! This can be a separate ticket but Ill let you know when it is done anyway!

1reaction
TuringLovesDeathMetalcommented, May 11, 2022

@PriPatel

For these two questions, here are my thoughts:

What happens with error messages? Do they still show in view mode?

Yes, I think they should still show in view mode. Was there a situation you ran into that made it feel like they shouldn’t?

What is the primary CTA?

For right now, “Explore from here” + “share”

Later, I imagine it will be drill-down options (#607) or there will be some way of sending users to related charts or dashboards containing this chart from within View mode.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Problems with Data in MultiCharts
MultiCharts can be running either in online mode that allows user to receive real-time and historical data from data vendors' servers, or customer...
Read more >
How to Setup TradingView Charts and Customize it (Episode ...
In this video, you'll learn how to setup TradingView charts and customize it to your own preference. SUBSCRIBE TO RAYNER'S YOUTUBE...
Read more >
Vision - Easy Chart - Ignition User Manual 8.0
Name Description Property Type Scripting Categ... Axis Font The font for axis labels. Font.axisLabelFont Appe... Bar Margin The margin to use for the 'Bar' pen...
Read more >
How to share charts in view-only mode - TradingView
The person you shared the chart with will see your chart in view-only mode, and example is here. Note that the person who...
Read more >
Layouts on tradingview charts, how to save and load?
Thing is if we do some drawings in desktop it should show in mobile … ... in trading view but everytime i open...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found