You should be able to remove `pages` from the results table

Description: What is it?

You should be able to have an option to remove the pages from the results table and just have everything appear in a giant table that you can scroll through.

Problem: What problem does this solve?

A lot of times helpful to just look at all rows at once scrolling up / down and get rough idea of row count returned when sorting but not that easy to see when paging and no row number

(Optional) Why: How do we know this is a real problem and worth solving?

https://getdbt.slack.com/archives/C026WJE4A69/p1644972891863359?thread_ts=1644794904.784429&cid=C026WJE4A69

Success: How will we know if we’ve solved this problem?

You’re able to un-page your results table

Audience: Who are we building this for?

Mostly data builders - people building charts and looking over their results tables.

What: Roughly, what does this look like in the product?

A toggle at the bottom where the pages are. Something that says show results on one page maybe?

[TuringLovesDeathMetal]

@PriPatel

what are your thoughts on using ‘results’ rather than ‘rows’?

ya! don’t really mind - tbh I didn’t notice the difference

How clear is ‘pagination’? Should it be more explicit?

pagination sounds a bit weird 😅 what about show all results?

We get rid of the ‘total rows’ input, as Im not sure how useful that is? (plus you have to run query every time)

^We need this input for running the SQL query. We limit the number of rows returned by the query using this value.

If we don’t have this, and you run a query on a table that’s say 1 billion rows, the load time in Lightdash would be insaaaaane.

[ZeRego]

@PriPatel

Is this is a general setting or only something applied per table? I imagine you don’t want to change the settings for every single table if you have a preference? eg. Sort of like gmail:

per table

Does the user need to hit ‘run query’ after they change their page display preferences?

No we already have all the results in the FE.

When the results are displayed on one page, does this mean we have one looong page, OR do we have a fixed height container that the user can scroll through? I’m picturing something like this blueprint example.

Both are possible, so we can go with whatever you think is best. imo is better to have a fixed height so all the page buttons can easily accessed.

Is there a limit to how many results we can display?

In theory no ( we might need a hard limit for performance or cost reasons 🤔 )

Will we need a loading spinner to appear after every X results displayed ?

No. Like I mentioned before the FE already has all the results in memory. This might change in the future.