question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[v2] Discussions about packaging

See original GitHub issue

First, thank you very much for this shining v2! That looks great in many aspects 👍

Now I’m working on updating PKGBUILD in community/nvchecker for v2. I found an issue and I have a question.

  • Not all needed files are installed by setup.py

https://github.com/lilydjwg/nvchecker/blob/376e5ad4991aeabeee77fa8956e0896d0ead0a67/setup.py#L23

This line is missing nvchecker.lib and nvchecker.httpclient. How about going back to automatic package discovery? For example,

diff --git a/setup.py b/setup.py
index d29728b..aa556dc 100755
--- a/setup.py
+++ b/setup.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 
-from setuptools import setup
+from setuptools import setup, find_namespace_packages
 import nvchecker
 
 # The complex upload command:
@@ -20,7 +20,7 @@ setup(
   platforms = 'any',
   zip_safe = False,
 
-  packages = ['nvchecker', 'nvchecker_source'],
+  packages = find_namespace_packages(exclude=["tests"]),
   install_requires = ['setuptools', 'toml', 'structlog', 'tornado>=6', 'pycurl'],
   extras_require = {
     'vercmp': ['pyalpm'],
  • Distribute ini2toml?

I believe most nvchecker users will need this after upgrading to v2. How about distributing it via setup.py for first few releases in v2? For example,

diff --git a/scripts/ini2toml b/scripts/nvchecker-ini2toml
similarity index 100%
rename from scripts/ini2toml
rename to scripts/nvchecker-ini2toml
diff --git a/setup.py b/setup.py
index d29728b..9123274 100755
--- a/setup.py
+++ b/setup.py
@@ -38,6 +38,7 @@ setup(
       'nvcmp = nvchecker.tools:cmp',
     ],
   },
+  scripts=['scripts/nvchecker-ini2toml'],
   package_data = {'nvchecker_source': ['vcs.sh']},
 
   classifiers = [

That will save time for users.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
yan12125commented, Oct 1, 2020

Saw v2 tagged, but I’m away from keyboard for Moon festival 😂 I will update the Arch package on Saturday night.

1reaction
lilydjwgcommented, Aug 26, 2020

Oops I didn’t know about find_namespace_packages and the manual way doesn’t add packages recursively.

However it’s still not done yet: #97 hasn’t been fully addressed. It’s also needed to update the master branch and write the docs for writing plugins.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Packaging Discussion - PrintPlanet.com
A general packaging forum with a range of topics, including digitally printed folding cartons and flexible packaging also covers digital press technology...
Read more >
Latest Packaging topics - Discussions on Python.org
Topic Replies Views Activity About the Packaging category 5 3639 March 11, 2019 Windows Python Installer not changing PATHEXT 2 116 December 22, 2022 Pip search...
Read more >
Packaging & Labeling - Forum - Forrager
Sometimes packaging is just as important as the product itself. ... Talk to others about creative packaging ideas, where to buy materials, ...
Read more >
Food Packaging Forum
The Food Packaging Forum provides independent and balanced information on issues related to food packaging and health. In doing so the Food Packaging...
Read more >
Packaging Lesson #2: What is the purpose of packaging?
Students are led through a guided discussion to brainstorm the purpose and function of packaging. From their list the class develops four general...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found