[v2] Discussions about packaging

First, thank you very much for this shining v2! That looks great in many aspects 👍

Now I’m working on updating PKGBUILD in community/nvchecker for v2. I found an issue and I have a question.

• Not all needed files are installed by setup.py

https://github.com/lilydjwg/nvchecker/blob/376e5ad4991aeabeee77fa8956e0896d0ead0a67/setup.py#L23

This line is missing nvchecker.lib and nvchecker.httpclient. How about going back to automatic package discovery? For example,

diff --git a/setup.py b/setup.py
index d29728b..aa556dc 100755
--- a/setup.py
+++ b/setup.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 
-from setuptools import setup
+from setuptools import setup, find_namespace_packages
 import nvchecker
 
 # The complex upload command:
@@ -20,7 +20,7 @@ setup(
   platforms = 'any',
   zip_safe = False,
 
-  packages = ['nvchecker', 'nvchecker_source'],
+  packages = find_namespace_packages(exclude=["tests"]),
   install_requires = ['setuptools', 'toml', 'structlog', 'tornado>=6', 'pycurl'],
   extras_require = {
     'vercmp': ['pyalpm'],

• Distribute ini2toml?

I believe most nvchecker users will need this after upgrading to v2. How about distributing it via setup.py for first few releases in v2? For example,

diff --git a/scripts/ini2toml b/scripts/nvchecker-ini2toml
similarity index 100%
rename from scripts/ini2toml
rename to scripts/nvchecker-ini2toml
diff --git a/setup.py b/setup.py
index d29728b..9123274 100755
--- a/setup.py
+++ b/setup.py
@@ -38,6 +38,7 @@ setup(
       'nvcmp = nvchecker.tools:cmp',
     ],
   },
+  scripts=['scripts/nvchecker-ini2toml'],
   package_data = {'nvchecker_source': ['vcs.sh']},
 
   classifiers = [

That will save time for users.

[yan12125]

Saw v2 tagged, but I’m away from keyboard for Moon festival 😂 I will update the Arch package on Saturday night.

[lilydjwg]

Oops I didn’t know about find_namespace_packages and the manual way doesn’t add packages recursively.

However it’s still not done yet: #97 hasn’t been fully addressed. It’s also needed to update the master branch and write the docs for writing plugins.