Accept URIs without `none+` and return URIs without `none+`

I see usability issues with none+ prefix in URI scheme:

• A user must specify a URL that starts with none+ to create an HttpClient with a ClientBuilder.
  • We could assume none+ exists when a user did not prepend it.
  • It becomes a little bit more ambiguous, I think it will not be that confusing. It’s like removing 0 from 0.1 (= .1).
• HttpClient.uri() returns a URI that starts with none+, which is somewhat confusing. For example, a user cannot convert the returned URI into a URL:

  HttpClient client = ...;
  client.uri().toURL(); // Fail
  

I’d like to:

• Make the none+ prefix optional when creating a client.
• Make ClientBuildParams.uri() return a URI without the none+ prefix.

[anuraaga]

I guess that seems like overkill - it seems fine to me then for uri() to return a + or not based on serialization format as proposed.

[ikhoon]

@rmohta Thanks for your interest.

Is it to be done only for none SerializationFormat, or for all?

IIRC, We have decided to apply only for none.

I am assuming, you would like as mentioned in below tests?

That’s right! It looks great.

By the way, our HTTP client doesn’t accept URL. https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/client/HttpClient.java#L229

If we choose this policy, I guess creating an HTTP client from URL would be more natural.

HttpClient client1 =...
URL url = client1.uri().toURL();
HttpClient client2 = HttpClient.builder(url)...build()

@trustin @minwoox WDYT?