Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add more parameters to `ArmeriaSettings`

See original GitHub issue

Currently, AmreriaSettings has only limited configuration parameters. If users want to set a parameter(e.g. maxRequestLength), they need to implement a bean:

@Bean
public ArmeriaServerConfigurator setMaxRequestLength() {
    return sb -> sb.maxRequestLength(...);
}

It would be nice if we provide more parameter setters to ArmeriaSettings from the ServerBuilder.

Issue Analytics

State:
Created 2 years ago
Comments:8 (7 by maintainers)

Top GitHub Comments

3reactions

ghkim3221commented, Jul 23, 2021

I need it. Let me work ✋

1reaction

ghkim3221commented, Jul 23, 2021

Does un-grouping really make things look bad?

I’m a bit worried that this will lead to missing synchronization between properties and methods like registration beans before 1.x in the past. 🤔

I prefer to use the builder method name itself so that we can easily check the synchronization between ArmeriaSettings and ServerBuilder using reflections.

I grouped for consistency since many spring-boot properties are grouped. However @ikhoon’s comment look reasonable to ungroup 👍