Check for over-exposed APIs
See original GitHub issueWe noticed in https://github.com/line/armeria/pull/2343 that there is a public interface for controlling timeout marked as internal-only in Javadoc. Generally, we should be able to avoid that by using the internal
package, but we may have some APIs that are exposed that shouldn’t be.
A couple I found are
- DefaultServiceRequestContext
- DefaultClientRequestContext
I think users are supposed to use request context through their interfaces so do these need to be public classes? If we need to allow users to instantiate these objects, it follow our pattern better to have factory methods on e.g. ServiceRequestContext
that returns ServiceRequestContext
by creating DefaultServiceRequestContext
instead of directly exposing the class I think. This would also allow hiding classes like TimeoutController
Issue Analytics
- State:
- Created 4 years ago
- Comments:13 (1 by maintainers)
Top Results From Across the Web
Android camera2 exposure issue. Preview is overexposed in ...
But when YUV ImageReader is used, on-screen preview may be overexposed depended on composition. I have to make note, that exposure metering ...
Read more >Videos appear overexposed - Canto Help Center
When uploading videos to Canto and certain other platforms, your videos may appear to be overexposed but appear fine on your computer.
Read more >UGC Photo Scoring - Everypixel API
When you need to filter out poor quality photos that users upload to your service, use the UGC photo scoring algorithm. It instantly...
Read more >Overexposed VS Underexposed Photos - How to Fix Them ...
An overexposed photo tends to be washed out and it looks much brighter than it should be due to too much light hitting...
Read more >Detect Face API - Cognitive Services APIs Reference - Microsoft
Face - Detect. Detect human faces in an image, return face rectangles, and optionally with faceIds, landmarks, and attributes. No image will be...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Yeah, that’s what I’m referring to. 😄
For the classes that cannot be hidden, we could introduce annotations like
@UnstableApi
(similar to Guava’s@Beta
).