Confusing behavior when constructing clients

We’ve added some client creation shortcuts in #2396 but I wonder if it hasn’t resulted in some spaghetti.

I feel that this code doesn’t produce the intended result

ClientFactory factory = ClientFactory.builder().useHttp2Preface(false).build();
ClientOptions options = ClientOptions.builder().responseTimeoutMillis(timeout).build();  // Ends up being essentially equivalent to default client options, but I thought I'm only specifying response timeout
WebClient.builder(...)
  .factory(factory) // Want to use custom factory
  .options(options) // But custom factory gets overridden by ClientFactory.ofDefault(), which is highly surprising
  .build();

Probably related to #2483 (though I found it coincidentally, heh)

[anuraaga]

I think we should remove factory from WebClientBuilder if we want to keep it on ClientOptions. It’s too hard to grok this relationship otherwise.

[trustin]

Ah, OK. Thanks for explanation. Makes sense.