Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Request time does not take into account connection creation

See original GitHub issue

Reported in https://line-armeria.slack.com/archives/C1NGPBUH2/p1574122806097100

I believe this is a regression after moving Endpoint selection to the begging of the request. We call startRequest only when about to send the request, but not anymore. This is affecting spans, but I think it also affects our totalDuration metric equally.

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:18 (1 by maintainers)

Top GitHub Comments

1reaction

anuraagacommented, Nov 19, 2019

Realized it may not be a regression and there from the start - startRequest takes a channel so it could only ever be called after connection is complete. I’m a bit confused since I thought we have heard evidence of people debugging DNS resolution slowness using metrics, but I guess they’ve used server latency instead of client latency to find that.

It’ll be quite a refactor to record start timing without a channel 😅

0reactions

trustincommented, Jan 30, 2020

Let me try to take a look into this soon.