Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Should not swallow errors of `TransientService`
See original GitHub issueI got a report that PrometheusExpositionService is not working without any error logs.
I investigated the reason by debugging the code with some break points.
There was a dependency mismatch and the following line raised NosuchMethodException.
https://github.com/line/armeria/blob/198c247f2e9092601e920f900412f3cd1c70d7e0/core/src/main/java/com/linecorp/armeria/server/metric/PrometheusExpositionService.java#L90
The error raised by PrometheusExpositionService was not logged, because the TransientServices are excluded from LoggingService by default.
It is difficult for users to detect errors early. Especially when they are upgrading Armeria versions.
I propose to change the sensible default behavior of LoggingService for the TransientService.
- As-Is: Do not leave logs for requests served by the
TransientService - To-Be: Leave a log for a failed request(5xx Server Error) even though the request is served by
TransientService.
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (5 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
👍 👍 👍
👍 👍