THttpService.validateRequestAndDetermineSerializationFormat on MediaType.parse(accept) failure behavior

@trustin

The following code will end with HTTP 406 for accept header such as text/plan, */*; q=0.5.

https://github.com/line/armeria/blob/master/thrift/src/main/java/com/linecorp/armeria/server/thrift/THttpService.java#L465

I have two concerns.

• MediaType.parse maybe not capable for accept header parsing according to https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
• When MediaType.parse ends with exception, how about using serializationFormat as the fallback output serialization format?

[anuraaga]

While thinking about HTTP encoding, I remembered this code that I copied as is from Netty

https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/server/http/encoding/HttpEncoders.java#L60

If we have a generic Accept header parsing mechanism, we should probably replace it too 😃

[trustin]

If we have a generic Accept header parsing mechanism, we should probably replace it too 😃

We currently rely on MediaType.parse() on this, so it can’t be used for accept-encoding or accept-language, but I’d love to see this happen someday…