Undeprecate `ctx.setRequest/ResponseTimeout()`?

We got some internal inquiry about what should a user do instead of ServiceRequestContext.setRequestTimeoutMillis(long). IIUC the current API, it has to be:

final requestStartTimeMillis = 
    ctx.log().ensureAvailable(RequestLogProperty.REQUEST_START_TIME)
             .requestStartTimeMillis();
ctx.setRequestTimeoutAt(Instant.ofEpochMillis(requestStartTimeMillis + timeout);

… which is not ideal.

On the other hand, I found a bug where the current setRequestTimeoutMillis() implementation uses extendRequestTimeout(), which means the timeout will not be set when there’s no timeout scheduled yet.

[anuraaga]

Sorry for accidentally closing issue >< On mobile it’s just one mistouch when wanting to scroll the page.

[anuraaga]

For some reason I can’t come to love this enum, but I guess it’s ok. It’s probably just preference towards deadline than timeouts which is a long sailed ship.

I think making this enum consistently from helps it a lot if possible. Maybe this

enum TimeoutAdjustment {
  /** Sets a timeout to be a given amount of time from the current time as returned by {@link System#nanoTime}. */
  NOW,

  /** Sets a timeout to be a given amount of time from when the current request began processing. */
  START,

  /** Sets a timeout to be a given amount of time from the end of the currently set timeout. */
  CURRENT // Or CURRENT_END?
  ;
}