Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Handle body when it's already parsed
See original GitHub issueMoved from #5
The problem is that we really do not know how req.body has been parsed by just checking its type (e.g. Firebase Cloud Functions). It’s straight forward when its type is string, but things go difficult when it’s an object. Calling .toString() cannot be a silver bullet as we do not know how it’s implemented. If it results in a different string from the original request body, the validation process will silently fail which I do not want to happen.
I will first make it work with a string and a buffer, and look into how an object can be handled. Any idea is welcomed.
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (4 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
After internal review, we decide to reject this PR as it’s not very safe to support this kind of option. There cannot be a silver-bullet function to revert an object into the original body buffer.
Rather than this, the case should be handled by using the
validateSignature()function directly.Great news! Let’s do this.