dispatcher client stats breaks admin dashboard

I’m looking at the admin dashboard for the gob app running in Kubernetes. When I try to view the “http” router, I see:

Here’s the metrics payload that produced the error:

metrics.txt

I think the issue is:

{
  "rt": {
    "http": {
      "client": {
        "$/inet/127.1/8282": {
          ...
        },
        "dispatcher": {
          "serial": {
            "queue_size": {
              "gauge": 0
            }
          }
        }
      }
    }
  }
}

The “dispatcher” key in the “client” map doesn’t match the TRANSFORMER_RE that we use to parse client ids in the js code. Maybe we should just skip all client ids that don’t match the regex? Or maybe those dispatcher stats aren’t scoped properly?

[adleong]

I believe this is caused by https://github.com/twitter/finagle/pull/629

[adleong]

Fixed!