k8s-alpha create assumes that public ssh key contains filename

Note: This error is only reproduced on mac.

The k8s-alpha plugin assumes that the public ssh key contains the filename, which I guess is not stable across different OS implementations. On mac, the default comment user@hostname, which does not match the key filename which the script checks for. As a result, the create command generates the warning “Your ssh private key must be added to your ssh-agent.” even if you have added the key. The workaround I used was to generate a key that the script accepted was

> ssh-keygen -b 4096 -t rsa -C "id_rsa"`
> ssh-add -K ~/.ssh/id_rsa
> linode-cli k8s-alpha create k8s --ssh-public-key ~/.ssh/id_rsa.pub

See Generating a new SSH key and adding it to the ssh-agent

[asauber]

With another report of this issue, I was able to track down the exact cause.

https://github.com/openssh/openssh-portable/blob/master/ssh-add.c#L275 If a key added to an agent doesn’t have a comment, then the comment that’s stored is the filepath of the key.

My keys are in RSA format, which don’t have comments. The OPENSSH format is popular now, which always have comments which default to user@hostname.

So, my assumption in the plugin that I can grab the filename from ssh-agent -l is definitely not true.

I’ll work on a fix.

[asauber]

Hi @kengu, I believe we addressed this concern with #110