An incorrect query is generated when using a TVP to insert data (`INSERT INTO ... SELECT ... FROM @Table`)

Linq2DB generates incorrect query when a table value parameter is used to insert records in the database.

Steps to reproduce

var recordList = new List<DataModel>();

// ...

static void Test()
{
    var parameter = new DataParameter("table", ToDataRecords(recordList), DataType.Structured, "dbo.MemoryOptimizedTableType");
    
    db.FromSql<DataModel>($"{parameter}")
        .Select(item => new DestTable()
        {
            Id = item.Id,
            Name = item.Name,
        })
        .Into(db.DestTable)
        .Insert();
}

// ...

static IEnumerable<SqlDataRecord> ToDataRecords(IEnumerable<DataModel> list)
{
    // ...
}

Generated query:

INSERT INTO [dbo].[DestTable] DEFAULT VALUES
SELECT
	*
FROM
	@table_1 [item]

Environment details

linq2db version: 3.1.6 Database Server: SQL Server 2019 Database Provider: Microsoft.Data.SqlClient Operating system: Windows Server 2019 .NET Framework: .NET Core 3.1

[sdanyliv]

You have to rewrite your query. This syntax requires providing which fields to insert.

db.FromSql<DataModel>($"{parameter}")
        .Select(item => new DestTable()
        {
            Id = item.Id,
            Name = item.Name,
        })
        .AsCte()
        .Into(db.DestTable)
             .Value(t => t.Id, item => item.Id)
             .Value(t => t.Name, item => iitem.Id)
        .Insert();

Also you can use the following syntax

db.FromSql<DataModel>($"{parameter}")
        .Select(item => new DestTable()
        {
            Id = item.Id,
            Name = item.Name,
        })
        .AsCte()
        .Insert(db.DestTable, item => new DestTable()
        {
            Id = item.Id,
            Name = item.Name,
        });

[Corey-M]

This appears to be the same problem I’m having trying to add an INTO clause to a query. The query produces all of the right fields in the right order for the INTO clause, but because I don’t use .Value(...) for each field I get INSERT INTO [target] DEFAULT VALUES... as my generated query.

I have 16 fields in this particular query. Adding each of them via .Value(...) would be tiresome when I’ve already constructed the record.

When .Insert<TSource, TTarget>(...) is called where TSource and TTarget are the same… can we just omit the DEFAULT VALUES please?