CTE involving temporal table does not translate the temporal table SQL keywords

this…

var cte = (
	from change in changeSet.TemporalAll()
	where change.Id == key
	select new
	{
		Change = change.Id,
		RowNumber = Sql.Ext.RowNumber()
			.Over()
			.PartitionBy(change.Id)
			.OrderByDesc(EF.Property<DateTime>(change, "PeriodStart"))
			.ToValue()
	})
	.AsCte("History")
	.Where(anon=>anon.RowNumber <=2)
	.ToLinqToDB();

…translates to this…

WITH [History] ([RowNumber], [Id])
AS
(
        SELECT
                ROW_NUMBER() OVER(PARTITION BY [change_1].[Id] ORDER BY [change_1].[PeriodStart] DESC),
                [change_1].[Id]
        FROM
                [Ephron.Metadata.DotNet].[Class] [change_1]
        WHERE
                [change_1].[Id] = @key_1
)
SELECT
        [anon].[Id],
        [anon].[RowNumber]
FROM
        [History] [anon]
WHERE
        [anon].[RowNumber] <= 2

… which is correct except for it is missing the temporal table keywords in the CTE…

FOR SYSTEM_TIME ALL

… it should be something like…

WITH [History] ([RowNumber], [Id])
AS
(
        SELECT
                ROW_NUMBER() OVER(PARTITION BY [change_1].[Id] ORDER BY [change_1].[PeriodStart] DESC),
                [change_1].[Id]
        FROM
                [Ephron.Metadata.DotNet].[Class] FOR SYSTEM_TIME ALL as [change_1]
        WHERE
                [change_1].[Id] = @key_1
)
SELECT
        [anon].[Id],
        [anon].[RowNumber]
FROM
        [History] [anon]
WHERE
        [anon].[RowNumber] <= 2

https://github.com/dotnet/efcore/blob/94be38cf68692d3e605175801add457936fa7331/src/EFCore.SqlServer/Query/Internal/SqlServerQuerySqlGenerator.cs

I’ll attempt to implement a fix in linq2db and see if the PR will be accepted.

[sdanyliv]

Already released.

[sdanyliv]

Will check what we can do here. Actually it needs support from linq2db side.