When commands function pointer changes, internal `commands` property is not changedSee original GitHub issue
Thank you for creating this component and open-sourcing it.
While using it I encountered an issue. Because of the implementation of
JSON.stringify is used,
this.validateCommands() is not called if the implementation of some function is changed.
I think a better compare function (based on comparing pointers) could resolve the issue. I need this because I dynamically change the behaviour of commands based on Redux state.
I might try to create a PR, I’m just very busy right now, so I keep it here if someone wants to take an initiative.
- Created 5 years ago
- Comments:10 (7 by maintainers)