Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
When commands function pointer changes, internal `commands` property is not changed
See original GitHub issueThank you for creating this component and open-sourcing it.
While using it I encountered an issue. Because of the implementation of CDU where JSON.stringify is used, this.validateCommands() is not called if the implementation of some function is changed.
https://github.com/js-rcon/react-console-emulator/blob/master/src/components/Terminal.jsx#L230
I think a better compare function (based on comparing pointers) could resolve the issue. I need this because I dynamically change the behaviour of commands based on Redux state.
I might try to create a PR, I’m just very busy right now, so I keep it here if someone wants to take an initiative.
Issue Analytics
- State:
- Created 5 years ago
- Comments:10 (7 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
This is fixed as of abead75.
Turns out this wasn’t fixed after all 😆 oops. It’s actually been fixed now in cee9b4865d53b5d95338dddfe77e55019e7a1ab6 and the v3.0.3 release.