Failures in the collection converted tests

Collections conversion tool for linux-system-roles converts the linux-system-roles tree structure to the collection tree structure and replaces the role value with FQCN in the yaml files as well as in the modules/module_utils.

This is just a heads-up; there are 2 cases the conversion tool cannot support.

1. direct access expecting the roles tree structure

tests/tests_unit.yml
- hosts: all
  name: execute python unit tests
  tasks:
    - name: Copy python modules
      copy:
        src: "{{ item }}"
        dest: /tmp/test-unit-1/
        local_follow: false
      loop:
        - ../library/network_connections.py
        - unit/test_network_connections.py
        - ../module_utils/network_lsr

1. requires git repository

tests/tests_integration_pytest.yml
- name: Run Pytest tests
  hosts: all
  vars:
    - rundir: /run/system-roles-test
  tasks:
    - file:
        state: directory
        path: "{{ rundir }}"
        recurse: true

    - command: git rev-parse --show-toplevel
      register: git_top_directory
      delegate_to: localhost

[tyll]

Regarding the tree structure, I suppose the tests can be adjusted to detect whether it is a role or collection structure and import files respectively.

Yes, something like that. I’m sure the are some sort of built-in variables or env. vars. (or even path structure) that can be used to determine if the test is being run against the “old-style” role or the role as a member of a collection.

Path structure should be easy:

if ../library/network_connections.py exists:
	# assume it is a role
elif PATH_FOR_COLLECTION exists:
    # assume it is a collection
else
    # something is wrong

[tyll]

Will ELN/CentOS Stream use collections?

Not sure what you mean. What is ELN? How do ELN/CentOS Stream currently use the network role?

ELN is the project name for developing future RHEL releases as part of Fedora: https://docs.fedoraproject.org/en-US/eln/

I guess I could also ask, will Fedora Rawhide ship a collection instead of a role in the linux-system-roles package? Will it use the upstream tests to test the collection in their CI?