addAutoIncrement generated wrong sql

Environment

Liquibase Version:3.8.8

Liquibase Integration & Version: run as jar File

Liquibase Extension(s) & Version: NO

Database Vendor & Version:PostgreSQL 11.1

Operating System Type & Version:Windows10

Description

The following change set produced Exception because the generater sql syntax is invalid. //it s working for db2 but doesn’t work for POSTGRESQL

Steps To Reproduce

<addAutoIncrement  tableName="MYTABEL"	columnName="ID" defaultOnNull="true" generationType="ALWAYS" incrementBy="1" startWith="1"/>

Actual Behavior

CREATE SEQUENCE public.MYTABEL_id_seq AS null NO CACHE NOORDER liquibase.exception.MigrationFailedException: Migration failed for change set path-ignored::db-changelog-tables-1.0.0::Reza: Reason: liquibase.exception.DatabaseException: ERROR: syntax error at or near “null”

Expected/Desired Behavior

ALTER TABLE MYTABEL DROP COLUMN ID; ALTER TABLE MYTABEL ADD COLUMN ID SERIAL PRIMARY KEY; COMMENT ON COLUMN MYTABEL.ID IS ‘The entry ID’;

[nvoxland]

I think the original issue was resolved by a different fix at some point. There was a problem where we weren’t handling the “sequence data type” setting correctly, and I think that’s where the null came from.

BUT, I’ll keep this open for testing with #2588 because the generationType/defaultOnNull validation error is fixed there, and the example in the REPO steps use incrementBy/startWith on postgresql which were fixed by that PR also.

[kataggart]

@nvoxland moving this to code review since that is where the PR is living now. Thanks!