drop-all fails when schema contains tables defined using postgresql 11 table partitioning

Environment

Liquibase Version: 3.8.9

Liquibase Integration & Version: Dropwizard 2.0.10

Liquibase Extension(s) & Version: NA

Database Vendor & Version: Postgresql 12.2

Operating System Type & Version: Postgresql:12 docker image

Description

When executing the liquibase:drop-alll , the following error occurs:

Caused by: liquibase.exception.DatabaseException: ERROR: cannot drop inherited constraint "XXXX_fkey" of relation "XXXX_y2020m10" [Failed SQL: (0) ALTER TABLE "public"."XXXX_y2020m10" DROP CONSTRAINT "XXXX_fkey"]
	at liquibase.executor.jvm.JdbcExecutor$ExecuteStatementCallback.doInStatement(JdbcExecutor.java:402)
	at liquibase.executor.jvm.JdbcExecutor.execute(JdbcExecutor.java:59)
	at liquibase.executor.jvm.JdbcExecutor.execute(JdbcExecutor.java:131)
	at liquibase.executor.jvm.JdbcExecutor.execute(JdbcExecutor.java:111)
	at liquibase.database.AbstractJdbcDatabase.dropDatabaseObjects(AbstractJdbcDatabase.java:801)
	at liquibase.command.core.DropAllCommand.run(DropAllCommand.java:88)

Steps To Reproduce

List the steps to reproduce the behavior.

• This is a partitioned table with a foreign key constraint like to following:

--liquibase formatted sql

-- changeset jh:some-change
create othertable (
id bigserial primary key,
somedata text );

create table thistable (
                                 id bigserial,
                                 otherid int references othertable(otherid) NOT NULL,
                                 thisdate timestamp with time zone NOT NULL,
                                
)  PARTITION BY RANGE (thisdate);

CREATE UNIQUE INDEX thistable_unique_idx ON thistable(id, thisdate);

CREATE TABLE thistable_y2020m6 PARTITION OF thistable FOR VALUES FROM ('2020-06-01 00:00:00')  TO ('2020-06-30 23:59:59+00');
CREATE TABLE thistable_y2020m7 PARTITION OF thistable FOR VALUES FROM ('2020-07-01 00:00:00')  TO ('2020-07-31 23:59:59+00');

[stevesaliman]

Looking into it further, I don’t think this is an issue with the Postgres JDBC driver. It supports partitioned tables, but it uses a different type for them, Liquibase isn’t using that type when it calls DatabaseMetadata.getTables.

The fix to this needs to be in JdbcSnapshot.getTables(). It has a ResultSetCache.SingleResultSetExtractor that declares a ResultSetCache.SingleResultSetExtractor() method, which needs to to add “PARTITIONED TABLE” to the list of types it passed to the JDBC driver when we’re in Postgres. Doing this will fix the problem, but I’m not certain what other side effects this change would have - I suspect they would be good ones. Also, as I suspected, we need to remove Foreign Keys from the types to include for this to all work.

I’ll submit a patch, and the good folks at Liquibase, who know the code base better than I do, can make sure there isn’t anything bad about the change.

[nvoxland]

I’ll close this issue as resolved, since #1650 solved this in 4.3, and there is the separate issue for including them in the diff.