Inject lighthouse initialisation parameters

Is your feature request related to a problem? Please describe. Every new lighthouse flag/ scan configuration/ whatever will require changes in the Audit class. Instead I think we should build the lighthouse parameters outside the Audit class, and inject it. I think it will give more flexibility for more complex configurations, and less risk for regression bugs in the future.

Describe the solution you’d like

module.exports = class Audit {
  constructor(lighthouseConfig) {
    this.lighthouseConfig = lighthouseConfig || lighthouse.defaultConfig
    }
  }
  ...

    this.lighthouseConfig.opts.port =  this.lighthouseConfig.opts.port || chromeInstance.port
    debug(`invoking lighthouse scan for: ${url}`)
    const scanResult = await lighthouse(url,   this.lighthouseConfig.opts, this.lighthouseConfig.config);
....

Describe alternatives you’ve considered Keep it the way it is:)

[zivkaziv]

NP… Thank you:)

[lirantal]

Zvika I’ll close this for now unless you’d want to pursue it later with some action where we can re-open it