Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

createComment is not a function error - lit and lit-html 2.3.0

See original GitHub issue

Which package(s) are affected?

Lit Core (lit / lit-html / lit-element / reactive-element)

Description

using vite and vitest error with latest version of lit Screenshot 2022-08-15 at 11 11 09 AM

Reproduction

Please check stackblitz URL

https://stackblitz.com/edit/vitejs-vite-omm8ny

Workaround

downgrade to lit@2.2.8 and lit-html@2.2.7 version

Is this a regression?

Yes. This used to work, but now it doesn’t.

Affected versions

2.3.0

Browser/OS/Node environment

Chrome 103 MacOSX Node 16

Issue Analytics

State:
Created a year ago
Comments:6 (3 by maintainers)

Top GitHub Comments

3reactions

augustjkcommented, Aug 15, 2022

I think the issue here is that vitest is a node test runner and by default uses the node export condition. Here’s some relevant comment from a maintainer: https://github.com/vitest-dev/vitest/issues/1588#issuecomment-1173312515

There appears to be an option to potentially override that here https://vitest.dev/config/#transformmode-web

I tried just grabbing all .js files and forcing the transform by inlining all the dependencies in your stackblitz repro and the test command does seem to work. https://stackblitz.com/edit/vitejs-vite-zwvume?file=vite.config.js

2reactions

augustjkcommented, Aug 18, 2022

While it’s work-aroundable, perhaps we can also add some check here to use an existing document if it exists.

https://github.com/lit/lit/blob/ecdb3bcd311772e227f6e2b8e73614471ddf2682/packages/lit-html/src/lit-html.ts#L347-L353