Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Failed typescript compilation

See original GitHub issue

Describe the bug

Today I upgraded this library from v1.4.1 to v1.4.4 and since then I’m getting the following error during typescript build:

node_modules/livekit-client/dist/src/index.d.ts:16:33 - error TS1005: ',' expected.

16 import RemoteVideoTrack, { type ElementInfo } from './room/track/RemoteVideoTrack';
                                   ~~~~~~~~~~~

I’m not sure if this is valid syntax, but I’ve never seen a type import together with a regular one in the same statement.

Reproduction

❯ yarn tsc --version
Version 4.4.4
❯ yarn tsc
[...]

Logs

No response

System Info

System:
    OS: macOS 12.5.1
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 462.61 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.18.3 - ~/.nvm/versions/node/v14.18.3/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 6.14.15 - ~/.nvm/versions/node/v14.18.3/bin/npm
  Browsers:
    Chrome: 106.0.5249.119
    Firefox: 105.0.3
    Safari: 15.6.1
  npmPackages:
    livekit-client: ^1.4.4 => 1.4.4



### Severity

annoyance

### Additional Information

_No response_

Issue Analytics

State:
Created a year ago
Comments:5 (3 by maintainers)

Top GitHub Comments

2reactions

lukasIOcommented, Oct 26, 2022

Agreed. The best case scenario would be allowing this repo to use newer typescript versions but still provide compatible .d.ts files for older typescript versions. I found https://github.com/sandersn/downlevel-dts which seems to be the main tool to achieve this. I’ll give it a try and open a PR if it works out.

1reaction

nightvisi0ncommented, Oct 27, 2022

I just checked the tsconfig but skipLibCheck is enabled in our project 🤔