Files edited externally are uploaded with 'watcher["files"]' set to false, if 'uploadOnSave' is set to true

Issue:

If uploadOnSave is true, then files saved externally will upload, even if watcher["files"] is false.

Relevant Settings:

{
    ...
    "uploadOnSave": true,
    "watcher": {
        "files": false,
        "autoUpload": false,
        "autoDelete": false
    }
}

Steps to duplicate:

• Create a new file myfile.txt
• Set uploadOnSave to true
• Set watcher["files"] to false
• Change myfile.txt with Notepad (or any external program) and save.
• Note that myfile.txt is uploaded to the server, even though watcher["files"] is false.

What should happen:

• When watcher["files"] is false, files changed externally should not upload, even when uploadOnSave is true.

Please fix this. It is very annoying. It causes my local .git/ files to upload to the server.

[liximomo]

@duanehutchins Now it works the way you like.

[liximomo]

A similar extension, ftp-sync, only uploads changed files when saved in the vscode editor (not from external sources).

That’s the reason why I write another one. I think that be aware of external change it’s a power, not a limitation. I will consider adding a config to change this behavior.