Sync to remote just upload all files from folder to ftp, no matter the diffs/changes

Expected Behavior

After SFTP: Sync to remote - SFTP plugin should retrieve files, diff them and upload to FTP only those files which have changed.

This bug appeared after the latest update at May, 17. Before that, everything was great.

Actual Behavior

After SFTP: Sync to remote - SFTP plugin just reupload ALL files to ftp, no matter, were they changed or not. Even if there’s no any difference between local project and the project on ftp - SFTP just upload all the project to ftp, file to file.

Steps to Reproduce the Problem

1. Choose SFTP: Sync to remote in Command pallette.
2. Select a folder to sync.
3. Wait for “diff” and then watch how SFTP uploads every single files from the folder to ftp, even with no difference.

Requisites (important to diagnose the problem!)

Extension Logs

1. Open User Settings.

   • On Windows/Linux - File > Preferences > Settings
   • On macOS - Code > Preferences > Settings

2. Set sftp.printDebugLog to true and reload vscode.

3. Reproduce the problem, get the logs from View > Output > sftp.

[info] config at /Users/xxx {"name":null,"protocol":"sftp","host":"xxx","connectTimeout":10000,"agent":null,"privateKeyPath":null,"passphrase":null,"interactiveAuth":false,"secure":false,"secureOptions":null,"passive":false,"remotePath":"/xxx/","uploadOnSave":true,"downloadOnOpen":false,"syncMode":"full","ignore":[".git",".vscode",".DS_Store","logs","xxx/node_modules"],"watcher":{"files":false,"autoUpload":false,"autoDelete":false},"concurrency":4,"context":"/xxx/}
[trace] run sync to remote task at /Users/xxx
[info] sync /Users/xxx

All paths are correct, i just cleared paths and credentials for the security reasons.
Everything was ok for a very long time and i did change nothing, plugin just became buggy after the latest update.

Specifications

• Version: sftp plugin 1.1.9
• Platform: macOS High Sierra 10.13.4

It’s a great plugin, pity it has broken. I wish there was a way to downgrade to previous version, which worked great.

Thank you!

[liximomo]

Good news. v1.6.0 will only transfer the changed files. If there is any problem, please create a new issue.

[Pilot-Marc]

I noticed this bug a few days ago, right after I updated VS Code - I think that’s the trigger that caused this bug.
Worth updating: Upload works (single file only) when uploading via the context menu, but the behavior to upload all files only happens when using the keyboard shortcut.