question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Size increased greatly in 6.10.0 due to getSideChannel

See original GitHub issue

I happened to check lib size in Bundlephobia before updating package and noticed the size has increased from 10 kB minified to 30 kB minified. From lib user viewpoint this is not an acceptable change.

Commit 7c1fcc53 dist/qs.js exposes it was the addition of getSideChannel that caused this.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:10
  • Comments:20 (10 by maintainers)

github_iconTop GitHub Comments

5reactions
Tofandelcommented, Mar 13, 2022

As promised, PR is done, it’s breaking change free and reduces the size of side channel by 19Kb, that is if using the require('side-channel/withoutInspector.js) file with the inspector it would be reduced by only 10Kb

4reactions
ljharbcommented, Mar 25, 2021

That’s a perfectly reasonable choice as well - although USP doesn’t support nested params, which is a very commonly needed feature in web dev.

The replacement I provided above seems like it should be more than sufficient if you only support WeakMaps.

I would definitely consider an option to disable cycle checking, though, and do a conditional require so that your bundler wouldn’t even include side-channel unless you wanted it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Developers - Size increased greatly in 6.10.0 due to getSideChannel -
Coming soon: A brand new website interface for an even better experience!
Read more >
qs.stringify Uncaught RangeError: Cyclic object value #403
1 reaction. Sorry, something went wrong. @ljharb ljharb mentioned this issue on Mar 24, 2021. Size increased greatly in 6.10.0 due to getSideChannel...
Read more >
New Features in the 6.10.0 Release - Aruba Networks
The following new features are introduced in the CLI in the 6.10.0 release. ... If the LUKS passphrase is long, and depending on...
Read more >
Issues · ljharb/qs · GitHub
Size increased greatly in 6.10.0 due to getSideChannel. #404 opened on Mar 23, 2021 by Merri · 20 · Stringifying array escape brackets...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found