Stringify with arrayFormat: comma, wrongfully encode comma in return

wrong result with stringifying

qs.stringify({ a: ['b', 'c'] }, { arrayFormat: 'comma' }) return a=b%2Cc

when it should return a=b,c

because parsing , as reserved character per RFC 3986 should split the array if we used a parser withcomma: true option and %2C (percent encoded comma) should be treated normally as text character

related to : #336 pr

[ananiy]

using { encode: false } options to fix this

[coatesap]

This doesn’t actually appear to have been fixed. The latest version still outputs a=b%2Cc. In fact the unit test also confirms that is the current behaviour:

st.equal(
  qs.stringify({ a: ['b', 'c', 'd'] }, { arrayFormat: 'comma' }),
  'a=b%2Cc%2Cd',
  'comma => comma'
);

Surely this is wrong though, as it means you can’t encode values that have commas in themselves?