Using enum for clear API

This proposal was originally borned in our discussion here.

Proposal (by @sobolevn):

“Maybe we could use enums more often? It really covers this case easily. And it is possible to statically check your code with enum.”

Here’s the sample code:

from enum import Enum

class PortRange(Enum):
      DEFAULT = (1, 65535)
      WELL_KNOWN = (1, 1023)
      EPHEMERAL = (49152, 65535)
      REGISTERED = (1024, 49151)

And then:

def port(self, range_: PortRange = PortRange.DEFAULT) -> int:

So, we want to discuss with community what is better? Let’s discuss.

If you like this idea, add 👍, otherwise 👎.

[lk-geimfari]

@sobolevn It’s for returning random gender, maybe it’s good idea to rename it to RANDOM?

[sobolevn]

I like the second one. That was my original point, when I have fired an issue.

I am not sure about RANDOM by the way. I have heard a lot of developers said that it does not belong there. That enum represent items. RANDOM is not an item.

Maybe it is not to late to replace it with a function?

 def mime_type(self, type_: Optional[MimeType] = None) -> str:
        if type_ is None:
              type_ = select_random_item(MimeType)
        ...
        return self.random.choice(MIME_TYPES[type_.value])