subscribeToInvoice() call forget invoices after nodejs restarts

If nodejs restarts at the time an invoice is held

invoice with hash: a76fa7f91fffca163edbb1373c0358b065dc216397f02d51761f10f588e3db19 is being held!

Node loses tracking of this event and when releasing, if the invoice is paid, but the subscribeToInvoice does not follow the normal workflow, the status is not changed to PAID_HOLD_INVOICE and as a consequence the buyer is not paid.

We need to think a way of avoid this situation, one is never restart nodejs if at least one invoice is held, but we need to have a procedure to follow if the server crashes.

[csralvall]

I’ve just tested it. It works perfectly. For the sake of completeness I updated my test cases results:

• Order = BUY.

  • Situation: The server restarts after invoice is paid and before the command /fiatsent is executed.
  • Result:
    1. The bot keeps waiting for the /fiatsent command.
    2. /fiatsent is executed.
    3. /release is executed.
    4. The operation is finished successfully.

• Order = BUY.

  • Situation: The server restarts after invoice is paid and before the command /release is executed.
  • Result:
    1. The bot keeps waiting for the /release command.
    2. /release is executed.
    3. The operation is finished successfully.

I will open a PR with the changes.

[csralvall]

Good! I will start testing by my own.