Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug on resize after having reached the bottom of the page

See original GitHub issue

Hi there,

I’ve noticed a small bug if you resize the window after having reached the bottom of the page. The transform value seems to exceed the new instance limit. It’s getting back to a normal behavior after scrolling again.

To reproduce the bug, simply scroll to the bottom of the page and then resize the window: https://locomotivemtl.github.io/locomotive-scroll/

Tested on latests Chrome (v78) and Firefox (v70) on Windows.

I’ve fixed this issue by updating the updateScroll method so that the the instance delta y property can’t exceed the instance limit and by then calling transform to reset the position in case it happens, however I’ve not dug deeply enough in the code to be sure it’s not just a dirty hack:

      key: "updateScroll",
      value: function updateScroll(e) {
        if (this.isScrolling || this.isDraggingScrollbar) {
          this.instance.scroll.y = lerp(this.instance.scroll.y, this.instance.delta.y, this.inertia * this.inertiaRatio);
        } else {
          // fix to avoid the limit to be exceeded on resize
          if(this.instance.delta.y > this.instance.limit) {
            this.instance.delta.y = this.instance.limit;
            // force transform to the max position (dirty hack?!)
            this.transform(this.el, this.instance.scroll.x, -this.instance.delta.y, 0);
          }
          this.instance.scroll.y = this.instance.delta.y;
        }
      }

(Edit: I was using v3.1.5, things may have changed by then)

Thank you very much folks for the awesome work!