Rename "request" to "sample", and refactor request_success/failure into one event

The word request makes no sense for a lot of non-http protocols. Users could be reporting things like the reception of async WebSocket messages, or the time to run a script. The word sample is more appropriate.

Having separate events for request_success and request_failure make no sense either, so I suggest we deprecate those (but support them for a long time) and just use a single one, sample(with a boolean parameter success).

Perhaps this should be done at the same time https://github.com/locustio/locust/issues/1413

[heyman]

What are your feelings about the other part, merging request_success/failure into a single event?

I don’t have a strong opinion about it. But if I were to choose today, I think I’d prefer a single event. So as long as we kept the old ones for backwards compatibility for a long time like you said, I think it’s a good idea to change it.

[cyberw]

@DennisKrone is working on a PR to add optional metadata to the event (basically anything you like, things like customer id is a good example).

We’ve also talked about adding the User object, and I think request/response make a lot of sense as well. We just need a sensible behaviour for non-http / custom clients as well.