Create Replica never returns if RunAsync is endless

In your Tests project, you have the following Test:

      [TestMethod]
       public async Task TestServiceState_InMemoryState_PromoteActiveSecondary()
       {
           var replicaSet = new MockStatefulServiceReplicaSet<MyStatefulService>(CreateStatefulService, CreateStateManagerReplica);
           await replicaSet.AddReplicaAsync(ReplicaRole.Primary, 1);
           await replicaSet.AddReplicaAsync(ReplicaRole.ActiveSecondary, 2);
           await replicaSet.AddReplicaAsync(ReplicaRole.ActiveSecondary, 3);

           const string stateName = "test";
           var payload = new Payload(StatePayload);

           //insert data
           await replicaSet.Primary.ServiceInstance.InsertAsync(stateName, payload);
           //promote one of the secondaries to primary
           await replicaSet.PromoteActiveSecondaryToPrimaryAsync(2);
           //get data
           var payloads = (await replicaSet.Primary.ServiceInstance.GetPayloadsAsync()).ToList();

           //data should match what was inserted against the primary
           Assert.IsTrue(payloads.Count == 1);
           Assert.IsTrue(payloads[0].Content == payload.Content);

           //the primary should not have any in-memory state
           var payloadsFromOldPrimary = await replicaSet[1].ServiceInstance.GetPayloadsAsync();
           Assert.IsTrue(!payloadsFromOldPrimary.Any());
       }

The problem is this test is not working, if service is executing endless loop in RunAsync, let’s say for background task.

Some details:

AddReplicaAsync will wait for CreateAsync:

        public async Task AddReplicaAsync(ReplicaRole role, long? replicaId = null, int activationDelayMs = 0)
        {
            var serviceContext = MockStatefulServiceContextFactory.Create(CodePackageActivationContext, ServiceTypeName, ServiceUri, Guid.NewGuid(), replicaId ?? _random.Next());
            var stateManager = _stateManagerFactory(serviceContext, _reliableStates);
            var replica = new MockStatefulServiceReplica<TStatefulService>(_serviceFactory, serviceContext, stateManager);
            await replica.CreateAsync(role);
            _replicas.Add(replica);
        }

and then CreateAsync will wait for RunAsync which will never return

        public async Task CreateAsync(ReplicaRole role)
        {
            await OpenAsync(ReplicaOpenMode.New);

            if (role == ReplicaRole.Primary)
            {
                await OpenServiceReplicaListeners();
                await ChangeRoleAsync(role);
                await RunAsync();
            }
            else
                await ChangeRoleAsync(role);
        }

My suggestion is to wait for RunAnync to be completed in CreateAsync. Thank you.

[loekd]

I’ve taken a similar route and changed the call to RunAsync into an invokation without an await within CreateAsync. The task is awaited when the service is closed or deleted. The CancellationToken passed to RunAsync is cancelled, just as it would be in the real runtime. Added a unit test to prove the functionality. @sportfort , @Patrick-Spiegel , @VaclavK thanks for the assistance in this issue! Please let me know if this is fixed in v3.4.10.

[VaclavK]

yeah the fix looks real good