Not all pushed packages are available

Hi Loïc,

I’m using BaGet for a month and I’ve pushed and used many packages without encounter any problem, but today I’ve pushed the 9th package and it is not listed in Visual Studio or in the server web. I’ve removed a package, and the last package I pushed appeared just for a while, after it has disapeared again.

In the server side I can see this warning:

warn: Microsoft.EntityFrameworkCore.Query[20500]
         The LINQ expression 'GroupBy([p].Id, [p])' could not be translated and will be evaluated locally.

System configuration LXC over Ubuntu 18.04 BaGet commit ed0e62d3bdf29aecc4edbfb1f2a48e140769165c Hosting environment: Development (how to change it?)

Thank you for your help and the good job.

[solidsloth]

Don’t we want the skip and take to occur after the grouping? I think what’s currently happening is the total list of ungrouped packages are being limited/paged, and then the limited list is being grouped. For example, if you had a single package with 20+ versions, the default query would skip 0 and take 20, which would only be grabbing the first 20 versions of the package, and the group that single package.

I think

var packages = await search
    .Where(p => p.Listed)
    .OrderByDescending(p => p.Downloads)
    .Skip(skip)
    .Take(take)
    .GroupBy(p => p.Id) // Move this
    .ToListAsync();

should be:

var packages = await search
    .Where(p => p.Listed)
    .OrderByDescending(p => p.Downloads)
    .GroupBy(p => p.Id) // To here
    .Skip(skip)
    .Take(take)
    .ToListAsync();

Now we’re getting packages grouped by package id, and then paging on those results.

[loic-sharma]

This should be fixed by https://github.com/loic-sharma/BaGet/commit/ef5970904c62b7c9cf712d8c4a64151774155c6b#diff-86483935118f023a4828d37181ae9416. Feel free to open a new issue if anything else comes up!