SimpleSchema.oneOf Issue (simple example included)

Below is the example case. One case has type: FirstSchema The other case has type: SimpleSchema.oneOf(String, Number, FirstSchema, ZeroSchema) Given the second case contains the first case within oneOf, it should work. Shouldn’t oneOf test for String, then Number, then FirstSchema, and pass once it tests FirstSchema to be a match?

// Import
import SimpleSchema from 'simpl-schema';

// Instantiate
Test = new Mongo.Collection('test');

// Define Schema
ZeroSchema = new SimpleSchema({
	zeroAlpha: Number,
	zeroBravo: Number
});
FirstSchema = new SimpleSchema({
	firstAlpha: String,
	firstBravo: String
});
SecondSchema = new SimpleSchema({
	secondAlpha: String,
	secondBravo: {
		//type: FirstSchema, // Comment the below and un-comment this to switch cases
		type: SimpleSchema.oneOf(String, Number, FirstSchema, ZeroSchema)
	}
});

// Attach Schema
Test.attachSchema(SecondSchema);

// Sample Data
myData = {
	secondAlpha: "test",
	secondBravo: {
		firstAlpha: "test",
		firstBravo: "test"
	}
};
Test.insert(myData); // Error: secondBravo.firstAlpha is not allowed by the schema

Also interesting note: if I do type: SimpleSchema.oneOf(String, Number, FirstSchema), i.e., remove the ZeroSchema part, it validates/inserts successfully.

[aldeed]

I’ve done some work on this, but it’s a substantial rewrite to the validation flow. Hopefully will have a solution.

[chrisbobbe]

Hello @aldeed , if you add the “Help Wanted” flag again, I’ll feel more comfortable working on a pull request. Again, I don’t want to interfere if you’re already working on it. Or, is there anyone else who’s familiar with the internals of the package? It might take me longer, since I’m not, but I’m willing to go ahead with it because this is so important.