Multiple Attribute Throws error

Hi thanks for this great project. I’m using version 2.0.10 and ran into an edge case that’s throwing an error. The problem is here and caused by modelValue being null.

modelValue is null because I wanted to reset the select to nothing as a cancel button has been clicked. Maybe checking for it’s existence on the offending line or defaulting it to an empty array might fix the problem.

[lordfriend]

I’ll review this

[ghiscoding]

Thanks for the reply @lordfriend in my case the quick fix was mostly to remove the possibility of getting an error thrown in the console and yes I have to say that I only changed the line that throw an error on my side. We want to avoid having code throwing error. If we look at the viewValue variable, then the only other place that it could throw an error is on line 1326.

So in the end, that would be 2 lines to change to avoid error thrown

// line 890
// change this
if(isMultiple && viewValue.length === 0) {

// to this
if(isMultiple && (!viewValue || viewValue.length === 0)) {

and next line

// line 1326
// change this
if((typeof count !== 'undefined') && viewValue.length > count) {
..
// to this
if((typeof count !== 'undefined') && (viewValue && viewValue.length > count)) {

This does not change the behavior of the code in any sense, except that it won’t throw false error when viewValue is null and the UI won’t be broken anymore, apart from the select being empty.

Thanks for your plugin, I now use it in all my projects 😃