proposal: output proper exit codes

I like how fast and light zora is, would it be possible for it to output proper exit codes? Or is that job of at the test-runner?

1. test case:

// wat.js
const test = require('zora')

test('what', t => {
    t.ok(false)
})

1. what I think should happen

$ node wat.js
$ echo $status
1

1. what is happening instead:

$ node wat.js
$ echo $status
0

[lorenzofox3]

@lorenzofox3 possible suggestion, what if we use a flag to tell it’s running against node, and that way you can output the correct exit code, eliminating the need to pipe anything just for exit code in CI (less deps).

Something like this: node test-file.js --node

The problem whether you read it from a flag or not is that at some point we would need in zora something like

if(typeof process !== 'undefined'){
   const code = failing ? 1 : 0;
   process.exit(code);
}

My experience has taught me this can be problematic for module bundlers for example: when they parse that branch they must understand this branch is only relevant for a given environment. It is even more troublesome as process is a native module and they might need to provide a shim for browsers, etc.

I am not saying that is not doable but it is quite a lot of trouble compared to adding a development dependency

That or just update the README and tell people it’s not giving proper exit codes. People like @TehShrike had already adopted zora on a number of his repos, only to find out it was giving him false positive because CI sees it’s always returning zero exit code.

I agree although most of the time as you run your tests locally first you should have few false positives and update your ci setup little by little as you update the code in your repos

I should definitely update the Readme though. Thanks for the advice

[TehShrike]

tap-exit-code@2 and tap-color@1.2 are both patched to set the correct status code on bail out.