question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Skyline Year is Weird

See original GitHub issue

I set the plugin_skyline_year to 0 so it will show the current year (2021) but it shows 2008.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
lowlightercommented, Jun 17, 2021

NaN is falsy (!!NaN === false), so a simple if (!year) might work.

Yes, plus it’s easier to understand it 👍

Is the metadata’s type value used for converting the value passed in the workflow?

Yes indeed 🙂

The reason behind is that GitHub passes all inputs as environment variables to actions, so these are implicitely casted to strings (that’s also why arrays and dictionnaries cannot be used currently in any action.yml, though I’ve seen that GitHub recently added new features to parse multilines strings into array in actions/core). It’s also the same for query parameters when using web instances, which are implicitely strings since there are no typing.

So although kind of hacky, the metadata.mjs parses the metadata.yml of each plugin to automatically validate and sanitize user inputs, with additional casting and defaulting to avoid inputs checks at the beginning of each plugin. It also kind of act as documentation as a bonus


Thanks a lot! It worked! 😁

Glad you were able to make it work!

2reactions
Th3Us3rcommented, Jun 17, 2021

Thanks a lot! It worked! 😁

Read more comments on GitHub >

github_iconTop Results From Across the Web

7 Secrets About The Nissan Skyline GT-R R34 - Top Speed
The Nissan Skyline GT-R R34 lasted for three years between 1999 and 2002. Here are some fun facts about this icon also called...
Read more >
What Happened To The Nissan Skyline GTR - YouTube
https://www.fitmentindustries.com/giveawayThe Nissan Skyline GTR ... But fast forward 16 years and this car came back with a vengeance.
Read more >
R33 Skyline spotlight | Hagerty Insider
The Nissan Skyline GT-R is at the top of any self-respecting JDM fan's automotive wish list. However, until just a few years ago, ......
Read more >
Ranking Every Generation Of Nissan Skyline GT-R, The JDM ...
The Nissan Skyline GT-R was for many years the ultimate in forbidden sports car fruit, a high performance Japanese masterpiece that only ...
Read more >
Every Nissan Skyline GT-R Generation Ranked Worst To Best
The car has evolved quite a bit over the years. ... The R33 Skyline GT-R is widely, perhaps unfairly, regarded as the awkward...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found