Please clarify using `DataType` for code completion

Hey, I’m having some trouble with code completion when I do this in my code:

export const loginObservable = createReactObservable<{ user: User | null }>(...)

The code that uses the above:

import { loginObservable } from "user"; // some imported workspace module

const {
  ObservableProvider: LoginProvider,
  useObservable: useLoginObservable,
} = loginObservable;

function App() {
  const { data } = useLoginObservable();
  ///...

Now, in VS Code, when I type data. I don’t get any suggestions for ‘user’ whatsoever. I dug into the library’s types and found:

export type DataType<T> = T | T[] | undefined;

Which is a bit unclear to me. Values in the ‘event bus’ can be either arrays or singular values? If so how would I use this with proper type checking? Thanks.

[amireldor]

Hi @luistak, forgive me for being so late in response!

Your API suggestion looks good. I’d however considered adding a limit to the length of values kept in every just to prevent potential memory issues. Maybe you could use an API like so for every:

const options = { every: true } // keep everything
// - or -
const options = {
  every: { keep: 20 } // keep last 20 values
}

Also, consider all or last as an alternative variable name than every.

[luistak]

Hi @amireldor the new major version was released along with the improvements we discussed, feel free to use it and please give us feedback if you find any problems or feedback.