Filtered middleware never run

Hi there,

I’m trying to replace Express with Polka in a small project, and I’m facing an issue where a “filtered” middleware is never run :

const polka = require('polka');
const serveStatic = require('serve-static');

/*
 *
 */

const app = polka();

// Always run, as expected
app.use((req, res, next) => {
  console.log(req.method, req.url);
  next();
});

// Never run, but I expect it to be when navigating to /admin/**/*
app.use('/admin', (req, res, next) => {
  console.log('  @admin!');
  next();
});

// Always run, as expected
app.use(serveStatic(__dirname + '/_static'));

/*
 *
 */

app.listen(4444, () => console.log('Listening on port 4444...'));

It’s probably a very silly error but I don’t see what I’m doing wrong here.

[flawyte]

Ok. Thank you!

[lukeed]

I would fix it by moving serve-static to its own path. Most of the time, you don’t need it running globally (it’s slow and induces a significant performance hit too).

Maybe something like this:

polka()
  .use('/assets' serveStatic)
  .use('/admin', ...)

Polkadot doesn’t have a router or middleware runner built in, so you would/could arrange it however you’d like! It’s not affected by anything in Polka, no 😃

There is a polka@next release out btw. It has the ordering changes so it might feel more comfortable/familiar to you