Rename the `this.name` to something other

Because I need to do some weird stuff like this

const programName = this.name;
delete this.name;

// where `this` is the `prog` which is the "instance" of calling sade()
const handler = Object.assign(taskObj.handler, this);

// ! restore, because the help() needs it
this.name = programName;

return handler;

The case. I override a bit the .action method, for few reasons. And in this method I have above code, because I need to return the handler function and I where I use it I need also access to the “instance”.

And in general, just “name” isn’t that good. Probably this.programName makes more sense.

[lukeed]

If you could extend Sade you’d still have this problem since the help text is built outside of the class, and that utility is passed the value. All it does it allow devs to manipulate the class in unforseen ways and then ping me when stuff breaks. No thanks, it does what it does

Really what you should have done here is initialize a singleton Sade instance and then exposed your own API that interfaced with the Sade instance privately. Would have worked just fine based on your description, and not been “ugly” - using it would have appeared like any other library usage.

---

I will take a look at this tomorrow. There are quite a few dependents now so I have to look thru some of them to see if any are reading the program name too.

[tunnckoCore]

Exactly, that’s again about design architecture problem of Sade. If it wasn’t doing a few things outside the class none of these issues would exist.

Really what you should have done here is initialize a singleton Sade instance and then exposed your own API that interfaced with the Sade instance privately.

Of course, I could create my own class or function and just replicate/mirror all the methods of Sade (like below), but that approach is unreliable and not future proof if Sade changes something (which probably won’t happen or won’t be so drastic, but still). Also, increases mine codebase unnecessarily and not because of some sane reason, but just because Sade wants to be closed for extending. Hence, the “O” in SOLID principles.

class Hela {
  constructor() {
    this.prog = sade('hela').version('3.0.0')
  }
  option(...args) {
    return this.prog.option(...args);
  }
  // and so on...
}

I will take a look at this tomorrow. There are quite a few dependents now so I have to look thru some of them to see if any are reading the program name too.

Cool, thanks. 😃