Promises that never resolve skip subsequent tests

I think this is a bug, but maybe I’m holding it wrong?

// tests/test.js
const { test } = require('uvu');

test('skips subsequent tests', async () => {
  await new Promise(() => {});
  throw new Error("isnt executed");
});

test("doesn't run", () => {
  throw new Error('doesnt run');
});

test.run();

This test file doesn’t fail and doesn’t run any tests. Tested in both node 16 and node 14.

Same behaviour using both the CLI and node directly.

$ npx uvu
tests/test.js

$ node tests/test.js
$

[tom-sherman]

After thinking about this a little I really think this is a separate issue to timeouts.

A test runner must ensure that test functions run to completion or throw an error. To me this is a core invariant a test runner must uphold. In other words tests should have two possible final states: “passed” and “failed”. Currently this behaviour in uvu introduces a third state of “not complete” but surfaces the result to the user as “passed”.

@lukeed Do you have any additional thoughts on this? I’d love for this issue to be reopened - I’m happy to implement @Katarn suggestion above.

Overall, this is something that your JS programs should not be doing

To summarise, I want to write tests to ensure that my JS programs aren’t falling into this trap.

[tom-sherman]

@lukeed Sorry for not being clear about the original intention of this issue - the behaviour I’m describing is that tests are skipped in some scenarios, which could lead to false positive test passes.

Maybe I’m missing something but #33 appears to be a feature request to control the timeout of tests, I was raising a point about the first test in my example causing the second test not to ever execute.