Sending Multiple Emails - Previous recipients remains in the following emails

Hi,

I am sending multiple emails with MailGun in the foreach loop and every next email is adding previous email address as recipient 😦

I am using DI for _email.

       await _email.To(emailAlert.Subscriber.Email)
                .Subject("My Subject")
                .Body(GetAlertBody(emailAlert), true)
                .SendAsync();

I can see in the MailGun log this, headers has 2 emails (not correct) while the recipient only one which is correct.

"message": {
        "headers": {
            "to": "[e-mail], [e-mail]",
            "subject": "My Subject"
        },
        "attachments": [],
        "size": 1175
    },
    "recipient": "[e-mail]",

Also in the Fiddler Raw I can see this, there shouldn’t be [e-mail]:

Host: api.mailgun.net

--1cf329c2-d30a-41d4-a1ec-8bce3a24fd60
Content-Type: text/plain; charset=utf-8
Content-Disposition: form-data; name=from

Uptime Monitor <[e-mail]>
--1cf329c2-d30a-41d4-a1ec-8bce3a24fd60
Content-Type: text/plain; charset=utf-8
Content-Disposition: form-data; name=to

 <[e-mail]>
--1cf329c2-d30a-41d4-a1ec-8bce3a24fd60
Content-Type: text/plain; charset=utf-8
Content-Disposition: form-data; name=to

 <[e-mail]>
--1cf329c2-d30a-41d4-a1ec-8bce3a24fd60
Content-Type: text/plain; charset=utf-8
Content-Disposition: form-data; name=subject

My Subject
--1cf329c2-d30a-41d4-a1ec-8bce3a24fd60
Content-Type: text/plain; charset=utf-8
Content-Disposition: form-data; name=html

Am I doing something incorrectly and SendAsync() just builds up somehow and doesn’t clear the recipient in the header?

Thanks.

[lukencode]

I actually think we should throw an exception if you try send the same email instance twice.

On Wed, 29 Jul 2020, 7:15 pm Luke Lowrey, [e-mail] wrote:

Hi mattias

Yes the factory will clear the the email data.

Thanks Luke

On Wed, 29 Jul 2020, 5:34 pm Mathias Raacke, [e-mail] wrote:

I ran into the same issue, which embarassingly caused users to receive e-mails with passwords from other users 😦

I sill don’t really understand why that is the case and where that’s mentioned in the docs. I don’t mean this as criticism, just as feedback on the usability / discoverability of the api and docs 😃

So if I understand correctly, if I change

IFluentEmail email; // injected by constructor injection

var message = _email .To(email) // …

to

IFluentEmailFactory email; // injected by constructor injection

var message = _email .Create() .To(email) // …

it should work as expected (previous recipients won’t receive additional emails)?

Regards, Mathias

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lukencode/FluentEmail/issues/117#issuecomment-665489317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2OWRZETHIYWE4COF42YTR57GGRANCNFSM4FQ5ZIXA .

[idbates]

This issue has just hit on on a production site with duplicate emails sent. Looking at the implementation for the To method I would have thought it safer to first clear the ToAddresses collection in the Data property - it might prevent chaining multiple calls to the To method but its hard to see why someone would do that and not simply pass a semicolon list or list of Address.