SmtpSender disposes itself after first send

I’m using Email.DefaultSender to set up SmtpSender as the sender, but upon the first send the SmtpClient object in SmtpSender is disposed, preventing any further sends until I set Email.DefaultSender to a new SmtpSender object.

That behavior is definitely not intentional I’m guessing? The root cause appears to be that SmtpSender is calling its own Dispose method after it sends an email (!).

Code to reproduce:

Email.DefaultSender = new SmtpSender();

Email
        .From("[e-mail]")
        .To("[e-mail]", "bob")
        .Subject("hows it going bob")
        .Body("yo dawg, sup?")
	.Send();

Email
        .From("[e-mail]")
        .To("[e-mail]", "bob")
        .Subject("hows it going bob")
        .Body("yo dawg, sup?")
	.Send();
// throws ObjectDisposedException

[kakone]

I agree that we should be able to pass our own SmtpClient and it should not be disposed by the Send method. So, I created https://github.com/lukencode/FluentEmail/pull/98/ to fix this.

[bjcull]

#89 now spins up and disposes the SmtpClient using the given function. Not ideal, but not broken.