Suggestion about ByteSplicer

Hi Luke, May I suggest the ByteSplicer Combine method accept only byte[] instead of object[] as a parameter?

https://github.com/lukevp/ESC-POS-.NET/blob/554802bb73e2de5b229c441468b013ae5fefa3d9/ESCPOS_NET/ByteSplicer.cs#L7-L20

I mention it, because it looks like this method is not ready to use other type of params. That would simplify a little bit your code and avoid potential exception to be thrown

public static byte[] Combine(params byte[] byteArrays)
{
    var builder = new ByteArrayBuilder();
    foreach (var byteArray in byteArrays)
        builder.Append(byteArray);

    return builder.ToArray();
}

[lukevp]

I’ll update this in the next version, thanks for the feedback!

[igorocampos]

Hmm, I see… There is sanitation before converting the string to byte[]. And this is going to be different depending on the emitter, is that it?

Yeah, in that case I agree with you