question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement new delegation design.

See original GitHub issue

To Do

David

  • rewrite so that it doesn’t use TmModal
  • align left side of fields with Atom logo
  • write unit tests
  • E2E test
  • warning dialog when user has zero atoms
    • Put space between warning icon and “Cannot Stake”
    • remove x button
    • remove horizontal line above footer
    • clicking on OK button without releasing shows outline larger than button
  • move Amount to bottom of form

Fede

  • write { bondDenom } within Amount field
  • make To field read-only - [x] allow selection of previously-staked validators in From field MOVED to #1293.
  • abbreviate From address
  • avoid redelegating to the same address
  • close window when clicking outside of it
  • autofocus Amount field
  • make Stake button greyed-out when amount is invalid

@jbibla , please link your design files here.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:20 (11 by maintainers)

github_iconTop GitHub Comments

2reactions
fabowebcommented, Sep 5, 2018

I agree with Jordan. I would see this as a replacement for PageBond. We can add the 2 buttons to the old PageValidator for now and replace the checkboxes (and shoppingCart logic) already.

1reaction
fabowebcommented, Sep 13, 2018

So that would basically turn the delegation into a redelegation, right ?

Yep. Maybe do delegation first and then do redelegation in another PR.

I’m asking because eventually we’ll end up splitting that POST endpoint to submit delegations

Let’s not handle problems we do not yet have. When the split happens, the logic on our hand probably can be easily changed.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Delegation Pattern - Best Practice Software Engineering
Often, delegation is the more flexible way to express a relationship between classes. This pattern is also known as "proxy chains". Several other...
Read more >
Design Patterns by Tutorials, Chapter 4: Delegation Pattern
The delegation pattern enables an object to use another “helper” object to provide data or perform a task rather than the task itself....
Read more >
The power of Delegate design pattern | Swift with Majid
This week we are going to talk about my favorite design pattern Delegate. Delegate is the most straightforward and powerful pattern.
Read more >
Delegate Design Pattern - Medium
The Delegate is a light weight pattern that other design patterns use — to ... This brings a new object to the design...
Read more >
Delegation pattern - Wikipedia
In software engineering, the delegation pattern is an object-oriented design pattern that allows object composition to achieve the same code reuse as ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found